Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Overlay's minimize button stays in hovered/focused state after restoring #34763

Closed
3 tasks done
indutny-signal opened this issue Jun 27, 2022 · 6 comments · Fixed by #34771
Closed
3 tasks done

Comments

@indutny-signal
Copy link
Contributor

Preflight Checklist

Electron Version

19.0.5

What operating system are you using?

Windows

Operating System Version

11

What arch are you using?

x64

Last Known Working Electron version

N/A

Expected Behavior

When hovering over a "minimize" button in titlebar overlay and clicking it, and then restoring the app - I expect that the button is restored to its original state:

image

Actual Behavior

Instead if I click "minimize" and then restore I see this:

image

Testcase Gist URL

No response

Additional Information

Originally reported in: signalapp/Signal-Desktop#5992

@indutny-signal
Copy link
Contributor Author

❤️

@kaizjen
Copy link

kaizjen commented Jul 24, 2022

I'm still having this issue in electron v19.0.8

@codebytere
Copy link
Member

That's correct. It was not released until 19.0.9.

@kaizjen
Copy link

kaizjen commented Jul 26, 2022

Sorry for the previous comment, but this issue still persists in 19.0.9, but only if the window was left in a maximized state before minimizing.

@codebytere
Copy link
Member

interesting - i'll check into it!

@codebytere
Copy link
Member

@wheezard thanks for surfacing this - just put up a PR to remedy it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants