test: add first-party-set chromium tests #34827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Jul 7, 2022
jkleinsc
approved these changes
Jul 7, 2022
|
No Release Notes |
|
I have automatically backported this PR to "20-x-y", please check out #34842 |
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
test: add first-part-set chromium feature tests
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
test: add first-part-set chromium feature tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
First party sets are now being used by Electron app developers. Although Electron itself does not contain API code for first party sets, it would be helpful to have a few small tests to protect against any upstream changes or breaks (for example, when upgrading a Chromium role).
This PR adds two small tests to test loading FPS within an app and from the command line.
Checklist
npm testpassesRelease Notes
Notes: none