app. Ispackaged is also false after it is packaged by electronic builder

[message163]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for a bug report that matches the one I want to file, without success.

Electron Version

16

What operating system are you using?

Windows

Operating System Version

window 11

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

import { app, BrowserWindow } from 'electron'

import path from 'path'
let win: BrowserWindow | null;

const createWindow = () => {

win = new BrowserWindow({
    webPreferences: {
        devTools:true,
        contextIsolation: false,
        nodeIntegration: true
    }
})

//  app.isPackaged  returns  false
if (app.isPackaged) {
    win.loadFile(path.join(__dirname, '../index.html'))
} else {
    win.loadURL(`http://${process.env['VITE_DEV_SERVER_HOST']}:${process.env['VITE_DEV_SERVER_PORT']}`)
}
}

app.whenReady().then(createWindow)

Actual Behavior

// app.isPackaged returns true

Testcase Gist URL

No response

Additional Information

No response

[RaisinTen]

what do you get when you print app.getPath('exe')?

[message163]

C:\Users\TR\Desktop\electron\electron.exe

[message163]

[RaisinTen]

I didn't get a chance to try to package an electron app using electron-builder yet but the reason why this happens is clear -

electron/shell/browser/api/electron_api_app.cc

Lines 988 to 1003 in 31be6ec

	bool App::IsPackaged() {
	auto env = base::Environment::Create();
	if (env->HasVar("ELECTRON_FORCE_IS_PACKAGED"))
	return true;
	base::FilePath exe_path;
	base::PathService::Get(base::FILE_EXE, &exe_path);
	base::FilePath::StringType base_name =
	base::ToLowerASCII(exe_path.BaseName().value());
	#if BUILDFLAG(IS_WIN)
	return base_name != FILE_PATH_LITERAL("electron.exe");
	#else
	return base_name != FILE_PATH_LITERAL("electron");
	#endif
	}

.
app.isPackaged works by checking if the name of the executable is electron. If it is so (which is true in your case), it assumes that it is not packaged, otherwise it thinks that it's packaged. If this is blocking your progress, you could try to set the environment variable, ELECTRON_FORCE_IS_PACKAGED, with any value you want and that would make electron think that it's always a packaged app.

I'd also like to know what version of electron or electron-builder where this problem was introduced in. That info would be very helpful (might help us understand if opening this issue in the electron-builder repo makes more sense, which you have already done in electron-userland/electron-builder#7034)!

[message163]

set ELECTRON_FORCE_IS_PACKAGED Or false

[RaisinTen]

@message163 I tried to package a dummy app using electron-builder v23.3.3 on Windows and I wasn't able to repro this locally because the name of the executable is the same as the name of the packaged app (which is not electron btw). I'm adding blocked/need-info ❌, so that you can share the steps for reproducing this. It would be really awesome if you're able to share a GitHub gist / repo that has the repro code!

[RaisinTen]

No follow-up for more than a month, closing.

[Yorenzz]

No follow-up for more than a month, closing.

I didn't get a chance to try to package an electron app using electron-builder yet but the reason why this happens is clear -

electron/shell/browser/api/electron_api_app.cc

Lines 988 to 1003 in 31be6ec

	bool App::IsPackaged() {
	auto env = base::Environment::Create();
	if (env->HasVar("ELECTRON_FORCE_IS_PACKAGED"))
	return true;
	base::FilePath exe_path;
	base::PathService::Get(base::FILE_EXE, &exe_path);
	base::FilePath::StringType base_name =
	base::ToLowerASCII(exe_path.BaseName().value());
	#if BUILDFLAG(IS_WIN)
	return base_name != FILE_PATH_LITERAL("electron.exe");
	#else
	return base_name != FILE_PATH_LITERAL("electron");
	#endif
	}

.
app.isPackaged works by checking if the name of the executable is electron. If it is so (which is true in your case), it assumes that it is not packaged, otherwise it thinks that it's packaged. If this is blocking your progress, you could try to set the environment variable, ELECTRON_FORCE_IS_PACKAGED, with any value you want and that would make electron think that it's always a packaged app.
I'd also like to know what version of electron or electron-builder where this problem was introduced in. That info would be very helpful (might help us understand if opening this issue in the electron-builder repo makes more sense, which you have already done in electron-userland/electron-builder#7034)!

when i change the productName of build parameter to the name except electron, app.isPackaged seems true after building