Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update libcxx filenames #35397

Merged
merged 2 commits into from
Aug 22, 2022
Merged

build: update libcxx filenames #35397

merged 2 commits into from
Aug 22, 2022

Conversation

VerteDinde
Copy link
Member

Description of Change

This PR updates the needed libcxx filenames in filenames.libcxx.gn after a recent Chromium bump.

Fixes main publish-linux job for nightly.

Checklist

Release Notes

Notes: none

@VerteDinde VerteDinde added fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases no-backport labels Aug 22, 2022
@VerteDinde
Copy link
Member Author

publish-linux job here is passing where it was previously failing - here it’s failing on upload, (which is expected, this isn’t a real release)

codebytere
codebytere reviewed Aug 22, 2022
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux failure is:

upload.py: error: unrecognized arguments: --UPLOAD_TO_STORAGE

which is not something i think is directly caused by this PR? that's here:

electron/.circleci/config/base.yml

Line 638 in 97b353a

script/release/uploaders/upload.py --verbose --UPLOAD_TO_STORAGE

however, i'm not sure why --UPLOAD_TO_STORAGE is all caps? other usage is lowecase and the file itself indicates that as well:

electron/script/release/uploaders/upload.py

Line 175 in ff804e3

parser.add_argument('-s', '--upload_to_storage',

I believe it's case-sensitive so maybe we should try changing that @VerteDinde 🤔

@VerteDinde
Copy link
Member Author

@codebytere Good call! You're right, I don't know why that's listed in uppercase here 🤔 I'll try pushing a fix here and seeing if it makes a difference

@VerteDinde VerteDinde merged commit d6d86f8 into main Aug 22, 2022
@VerteDinde VerteDinde deleted the update-libcxx-filenames branch August 22, 2022 20:11
@release-clerk
Copy link

release-clerk bot commented Aug 22, 2022

No Release Notes

@VerteDinde
Copy link
Member Author

/trop run backport-to 21-x-y

@trop
Copy link
Contributor

trop bot commented Aug 29, 2022

The backport process for this PR has been manually initiated - sending your PR to 21-x-y!

@trop trop bot mentioned this pull request Aug 29, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Aug 29, 2022

I have automatically backported this PR to "21-x-y", please check out #35497

@trop trop bot added in-flight/21-x-y merged/21-x-y PR was merged to the "21-x-y" branch. and removed in-flight/21-x-y labels Aug 29, 2022
@commit-lint commit-lint bot mentioned this pull request Nov 11, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@VerteDinde @khalwa
build: update libcxx filenames (electron#35397)
a92e66b 
* build: update libcxx filenames

* build: change upload_to_storage variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases merged/21-x-y PR was merged to the "21-x-y" branch. no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VerteDinde @codebytere