ci: fix appveyor x64 tests #35406
Merged
ci: fix appveyor x64 tests #35406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
force-pushed
the
fix-x64-tests
branch
from
ea6ae29
to
6798b75
Compare
codebytere
approved these changes
Aug 23, 2022
zcbenz
approved these changes
Aug 25, 2022
|
No Release Notes |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* ci: fix appveyor x64 tests * extract builtins-pgo to correct directory Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Seeing several appveyor failures on PRs with unrelated changed (e.g. https://ci.appveyor.com/project/electron-bot/electron-x64-testing/builds/44541167/job/t510wg0a0mprn94c#L3197).
In the latest Chrome roll, we saw similar failures when the
v8\tools\builtins-pgofolder wasn't persisted for tests. The recent split in "Build" and "Test" workflows resulted in this folder being empty during tests, which likely causes this failure. This PR zipsv8\tools\builtins-pgoto upload, then re-download for use during the test workflow.Checklist
npm testpassesRelease Notes
Notes: none