fix: pass rfh instances through to the permission helper #35419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
reviewed
Aug 24, 2022
deepak1556
approved these changes
Aug 24, 2022
MarshallOfSound
added
semver/patch
MarshallOfSound
force-pushed
the
fix-frame-permission
branch
from
5eab3a0
to
d2b55fb
Compare
codebytere
approved these changes
Aug 26, 2022
|
No Release Notes |
|
I was unable to backport this PR to "18-x-y" cleanly; |
|
I was unable to backport this PR to "20-x-y" cleanly; |
|
I was unable to backport this PR to "19-x-y" cleanly; |
|
I have automatically backported this PR to "21-x-y", please check out #35467 |
trop
bot
added
in-flight/21-x-y
merged/21-x-y
miniak
pushed a commit
that referenced
this pull request
Oct 11, 2022
* fix: pass rfh instances through to the permission helper * refactor: use WeakDocumentPtr instead of frame node id * fix: handle missing initiator document * fix: dispatch openExternal event for top level webview navs still
miniak
pushed a commit
that referenced
this pull request
Oct 11, 2022
* fix: pass rfh instances through to the permission helper * refactor: use WeakDocumentPtr instead of frame node id * fix: handle missing initiator document * fix: dispatch openExternal event for top level webview navs still
miniak
pushed a commit
that referenced
this pull request
Oct 11, 2022
* fix: pass rfh instances through to the permission helper * refactor: use WeakDocumentPtr instead of frame node id * fix: handle missing initiator document * fix: dispatch openExternal event for top level webview navs still
miniak
pushed a commit
that referenced
this pull request
Oct 11, 2022
miniak
pushed a commit
that referenced
this pull request
Oct 11, 2022
MarshallOfSound
added a commit
that referenced
this pull request
Oct 11, 2022
fix: pass rfh instances through to the permission helper (#35419) Co-authored-by: Samuel Attard <sam@electronjs.org>
MarshallOfSound
added a commit
that referenced
this pull request
Oct 11, 2022
fix: pass rfh instances through to the permission helper (#35419) Co-authored-by: Samuel Attard <sam@electronjs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some permission helper methods weren't passing the render frame host through all the way, this fixes it so they do.
Notes: no-notes