Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix missing includes in code example #35479

Conversation

RedSparrowEU
Copy link
Contributor

@RedSparrowEU RedSparrowEU commented Aug 28, 2022

Description of Change

Close #35157.

This change adds the required lines to the sample code so that it can be used directly via copy/paste without any hassle.

Checklist

  • PR description included and stakeholders cc'd
  • relevant documentation is changed or added
  • PR release notes describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense]

Release Notes

Notes: none

@welcome
Copy link

welcome bot commented Aug 28, 2022

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours labels Aug 28, 2022
@zcbenz zcbenz added semver/none no-backport and removed semver/patch backwards-compatible bug fixes labels Aug 29, 2022
@zcbenz zcbenz changed the title docs: update code in doc L188-203 #35157 docs: fix missing includes in code example Aug 29, 2022
@electron-cation electron-cation bot added the semver/patch backwards-compatible bug fixes label Aug 29, 2022
@codebytere codebytere added semver/patch backwards-compatible bug fixes and removed semver/none semver/patch backwards-compatible bug fixes labels Aug 29, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 29, 2022
@ckerr ckerr force-pushed the Wrong-usage-of-ipcMain.handle-in-tutorial-preload branch from 7724938 to 9b04641 Compare August 30, 2022 16:34
@zcbenz zcbenz force-pushed the Wrong-usage-of-ipcMain.handle-in-tutorial-preload branch from 9b04641 to fc71c1e Compare September 1, 2022 07:58
@codebytere codebytere merged commit c16baa0 into electron:main Sep 7, 2022
@welcome
Copy link

welcome bot commented Sep 7, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Sep 7, 2022

No Release Notes

khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Wrong usage of ipcMain.handle in /tutorial-preload
4 participants