Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --proxy-bypass-list command line argument #3550

Merged
merged 4 commits into from
Nov 24, 2015

Conversation

etiktin
Copy link
Contributor

@etiktin etiktin commented Nov 22, 2015

Depends on electron-archive/brightray#179

Explanation copied from the brightray PR:

This PR adds support for the --proxy-bypass-list command line argument. It enables you to decide on hosts that should bypass the proxy server set by --proxy-server. For example if your app talks to a local web server (e.g. http://127.0.0.1:8080), you probably don't want it to go through the proxy server (how will it resolve 127.0.0.1 to the correct host?), so you can use --proxy-bypass-list="127.0.0.1:8080" or the more general --proxy-bypass-list="<local>".
The value can contain more than one host, separated by semi-colon. See examples at: https://www.chromium.org/developers/design-documents/network-settings

This PR adds the documentation for this feature.

@etiktin etiktin changed the title Add support for --proxy-bypass-list Add support for --proxy-bypass-list command line argument Nov 23, 2015
@zcbenz
Copy link
Member

zcbenz commented Nov 24, 2015

👍

zcbenz added a commit that referenced this pull request Nov 24, 2015
Add support for --proxy-bypass-list command line argument
@zcbenz zcbenz merged commit bab603d into electron:master Nov 24, 2015
zcbenz added a commit that referenced this pull request Nov 24, 2015
@etiktin etiktin deleted the support_proxy_bypass_list branch November 24, 2015 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants