Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add IPC validation guideline link in checklist #35573

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

aryanshridhar
Copy link
Contributor

@aryanshridhar aryanshridhar commented Sep 4, 2022

Description of Change

Pr #33369 added a new security guideline leaving the checklist section unmodified.
This pr essentially adds its corresponding link to checklist :)

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours labels Sep 4, 2022
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the future @aryanshridhar please check off appropriate boxes in the PR body :)

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 5, 2022
@jkleinsc
Copy link
Contributor

Merging as CI failure unrelated to PR change.

@jkleinsc jkleinsc merged commit f244e75 into electron:main Sep 13, 2022
@release-clerk
Copy link

release-clerk bot commented Sep 13, 2022

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants