Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve registerFileProtocol example #35580

Merged
merged 3 commits into from
Sep 7, 2022
Merged

docs: improve registerFileProtocol example #35580

merged 3 commits into from
Sep 7, 2022

Conversation

KishanBagaria
Copy link
Contributor

Description of Change

Using url.fileURLToPath will handle correctly handle cases where the custom URI includes %20 unlike path.normalize

Release Notes

Notes: none

@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes labels Sep 6, 2022
@welcome
Copy link

welcome bot commented Sep 6, 2022

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 6, 2022
@erickzhao erickzhao requested a review from a team September 6, 2022 23:55
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 7, 2022
@codebytere
Copy link
Member

@KishanBagaria would you mind pushing an empty commit to kick lint?

@codebytere codebytere added no-backport target/19-x-y target/21-x-y PR should also be added to the "21-x-y" branch. and removed no-backport labels Sep 7, 2022
@jkleinsc
Copy link
Contributor

jkleinsc commented Sep 7, 2022

Merging as CI failure unrelated to PR change.

@jkleinsc jkleinsc merged commit 3a6d6ff into electron:main Sep 7, 2022
@welcome
Copy link

welcome bot commented Sep 7, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Sep 7, 2022

No Release Notes

@KishanBagaria KishanBagaria deleted the patch-1 branch September 7, 2022 18:45
@trop trop bot mentioned this pull request Sep 7, 2022
Merged
trop bot pushed a commit that referenced this pull request Sep 7, 2022
@KishanBagaria @electron-bot
docs: improve registerFileProtocol example (#35580)
1d3bcc8 
* improve registerFileProtocol example

* link ProtocolResponse

* kick lint
trop bot pushed a commit that referenced this pull request Sep 7, 2022
@KishanBagaria @electron-bot
docs: improve registerFileProtocol example (#35580)
c166054 
* improve registerFileProtocol example

* link ProtocolResponse

* kick lint
@trop trop bot mentioned this pull request Sep 7, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Sep 7, 2022

I have automatically backported this PR to "20-x-y", please check out #35598

@trop trop bot added the in-flight/20-x-y label Sep 7, 2022
@trop trop bot removed the target/20-x-y label Sep 7, 2022
@trop
Copy link
Contributor

trop bot commented Sep 7, 2022

I have automatically backported this PR to "21-x-y", please check out #35599

@trop trop bot added in-flight/21-x-y merged/21-x-y PR was merged to the "21-x-y" branch. and removed target/21-x-y PR should also be added to the "21-x-y" branch. labels Sep 7, 2022
jkleinsc pushed a commit that referenced this pull request Sep 13, 2022
@trop @KishanBagaria
docs: improve registerFileProtocol example (#35599)
fad97e0 
docs: improve registerFileProtocol example (#35580)

* improve registerFileProtocol example

* link ProtocolResponse

* kick lint

Co-authored-by: Kishan Bagaria <hi@kishan.info>
jkleinsc pushed a commit that referenced this pull request Sep 13, 2022
@trop @KishanBagaria
docs: improve registerFileProtocol example (#35598)
c19f09e 
docs: improve registerFileProtocol example (#35580)

* improve registerFileProtocol example

* link ProtocolResponse

* kick lint

Co-authored-by: Kishan Bagaria <hi@kishan.info>
@commit-lint commit-lint bot mentioned this pull request Dec 12, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@KishanBagaria @khalwa
docs: improve registerFileProtocol example (electron#35580)
a56b337 
* improve registerFileProtocol example

* link ProtocolResponse

* kick lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

@erickzhao erickzhao erickzhao approved these changes

Assignees
No one assigned
Labels
documentation 📓 merged/21-x-y PR was merged to the "21-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KishanBagaria @codebytere @jkleinsc @erickzhao