Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typescript error in code samples #35641

Merged
merged 1 commit into from
Sep 13, 2022
Merged

docs: fix typescript error in code samples #35641

merged 1 commit into from
Sep 13, 2022

Conversation

leonschwanitz
Copy link
Contributor

@leonschwanitz leonschwanitz commented Sep 12, 2022 •
edited by ckerr

Fixed a typescript warning / error in the example code

  • [ x ] relevant documentation is changed or added

Notes: None

@welcome
Copy link

welcome bot commented Sep 12, 2022

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 12, 2022
@leonschwanitz leonschwanitz changed the title Fixed typescript error Docs: Fixed typescript error Sep 12, 2022
@ckerr ckerr changed the title Docs: Fixed typescript error docs: fix typescript error in documentation Sep 12, 2022
@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes labels Sep 12, 2022
@ckerr ckerr changed the title docs: fix typescript error in documentation docs: fix typescript error in code samples Sep 12, 2022
ckerr
ckerr approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 13, 2022
@jkleinsc jkleinsc added target/19-x-y target/21-x-y PR should also be added to the "21-x-y" branch. labels Sep 13, 2022
@jkleinsc jkleinsc merged commit 200153d into electron:main Sep 13, 2022
@welcome
Copy link

welcome bot commented Sep 13, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Sep 13, 2022

No Release Notes

This was referenced Sep 13, 2022
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Sep 13, 2022

I have automatically backported this PR to "19-x-y", please check out #35654

@trop
Copy link
Contributor

trop bot commented Sep 13, 2022

I have automatically backported this PR to "20-x-y", please check out #35655

@trop
Copy link
Contributor

trop bot commented Sep 13, 2022

I have automatically backported this PR to "21-x-y", please check out #35656

@trop trop bot added in-flight/20-x-y and removed target/20-x-y target/21-x-y PR should also be added to the "21-x-y" branch. labels Sep 13, 2022
@leonschwanitz leonschwanitz deleted the patch-1 branch September 13, 2022 17:07
@trop trop bot added merged/20-x-y merged/21-x-y PR was merged to the "21-x-y" branch. and removed in-flight/20-x-y labels Sep 13, 2022
@commit-lint commit-lint bot mentioned this pull request Jan 2, 2023
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@leonschwanitz @khalwa
docs: fix typescript error in code samples (electron#35641)
f3bef1f 
Fixed typescript error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
documentation 📓 merged/21-x-y PR was merged to the "21-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leonschwanitz @ckerr @jkleinsc