Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix wording mistake in security.md section 4 #35682

Merged
merged 2 commits into from
Sep 20, 2022
Merged

docs: fix wording mistake in security.md section 4 #35682

merged 2 commits into from
Sep 20, 2022

Conversation

sebastianvitterso
Copy link
Contributor

Description of Change

Under "4. Process Sandboxing", it said "For mor information on what contextIsolation is..." which was the previous section (copied from there). This updates it to say "For more information on what Process Sandboxing is...".

Checklist

Release Notes

Notes: no-notes

@sebastianvitterso
Update security.md
bcdc9fc 
Under "4. Process Sandboxing", it said "For mor information on what `contextIsolation` is..." which was the previous section (copied from there). This updates it to say "For more information on what Process Sandboxing is..."
@welcome
Copy link

welcome bot commented Sep 15, 2022

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 15, 2022
@sebastianvitterso sebastianvitterso changed the title Update security.md docs: fix wording mistake in security.md section 4 Sep 15, 2022
@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes and removed new-pr 🌱 PR opened in the last 24 hours labels Sep 15, 2022
@erickzhao erickzhao added target/20-x-y target/21-x-y PR should also be added to the "21-x-y" branch. labels Sep 19, 2022
@jkleinsc jkleinsc merged commit b1d7b30 into electron:main Sep 20, 2022
@welcome
Copy link

welcome bot commented Sep 20, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Sep 20, 2022

No Release Notes

@trop trop bot mentioned this pull request Sep 20, 2022
Merged
trop bot pushed a commit that referenced this pull request Sep 20, 2022
@sebastianvitterso @electron-bot
docs: fix wording mistake in security.md section 4 (#35682)
1c08583 
Update security.md

Under "4. Process Sandboxing", it said "For mor information on what `contextIsolation` is..." which was the previous section (copied from there). This updates it to say "For more information on what Process Sandboxing is..."
trop bot pushed a commit that referenced this pull request Sep 20, 2022
@sebastianvitterso @electron-bot
docs: fix wording mistake in security.md section 4 (#35682)
37a2a85 
Update security.md

Under "4. Process Sandboxing", it said "For mor information on what `contextIsolation` is..." which was the previous section (copied from there). This updates it to say "For more information on what Process Sandboxing is..."
@trop trop bot mentioned this pull request Sep 20, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Sep 20, 2022

I have automatically backported this PR to "20-x-y", please check out #35742

@trop
Copy link
Contributor

trop bot commented Sep 20, 2022

I have automatically backported this PR to "21-x-y", please check out #35743

@trop trop bot added in-flight/21-x-y and removed target/21-x-y PR should also be added to the "21-x-y" branch. labels Sep 20, 2022
@trop trop bot added the merged/20-x-y label Sep 21, 2022
codebytere pushed a commit that referenced this pull request Sep 21, 2022
@trop @sebastianvitterso
docs: fix wording mistake in security.md section 4 (#35742)
3f7f4de 
docs: fix wording mistake in security.md section 4 (#35682)

Update security.md

Under "4. Process Sandboxing", it said "For mor information on what `contextIsolation` is..." which was the previous section (copied from there). This updates it to say "For more information on what Process Sandboxing is..."

Co-authored-by: Sebastian Vittersø <37065184+sebastianvitterso@users.noreply.github.com>
@trop trop bot removed the in-flight/20-x-y label Sep 21, 2022
@trop trop bot added the merged/21-x-y PR was merged to the "21-x-y" branch. label Sep 21, 2022
jkleinsc pushed a commit that referenced this pull request Sep 21, 2022
@trop @sebastianvitterso
docs: fix wording mistake in security.md section 4 (#35743)
199ccfd 
docs: fix wording mistake in security.md section 4 (#35682)

Update security.md

Under "4. Process Sandboxing", it said "For mor information on what `contextIsolation` is..." which was the previous section (copied from there). This updates it to say "For more information on what Process Sandboxing is..."

Co-authored-by: Sebastian Vittersø <37065184+sebastianvitterso@users.noreply.github.com>
@trop trop bot removed the in-flight/21-x-y label Sep 21, 2022
@commit-lint commit-lint bot mentioned this pull request Jan 16, 2023
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@sebastianvitterso @khalwa
docs: fix wording mistake in security.md section 4 (electron#35682)
f87d8f5 
Update security.md

Under "4. Process Sandboxing", it said "For mor information on what `contextIsolation` is..." which was the previous section (copied from there). This updates it to say "For more information on what Process Sandboxing is..."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@erickzhao erickzhao erickzhao approved these changes

Assignees
No one assigned
Labels
documentation 📓 merged/21-x-y PR was merged to the "21-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sebastianvitterso @jkleinsc @MarshallOfSound @erickzhao