Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add missing .eslintrc.json files to limit imports properly #35719

Merged
merged 1 commit into from Sep 20, 2022
Merged

chore: add missing .eslintrc.json files to limit imports properly #35719

merged 1 commit into from Sep 20, 2022

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Sep 19, 2022 •
edited

Description of Change

We only had this .eslintrc.json in lib/browser limiting the imports to electron/main.
Do the same for the renderers and common.

Follow-up to #24512

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 19, 2022
@miniak miniak added semver/patch backwards-compatible bug fixes target/19-x-y target/21-x-y PR should also be added to the "21-x-y" branch. labels Sep 19, 2022
@miniak miniak self-assigned this Sep 19, 2022
@ckerr
Copy link
Member

ckerr commented Sep 19, 2022 •
edited

ninja: error: '../../electron/node_modules/@primer/octicons/build/build.css', needed by 'gen/electron/js/default_app/electron/default_app/octicon/build.css', missing and no known rule to make it

win-ia13-testing CI failure looks unrelated to PR

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 20, 2022
@miniak
Copy link
Contributor Author

miniak commented Sep 20, 2022

@ckerr everything is green now

@ckerr ckerr merged commit 99f4a42 into main Sep 20, 2022
@ckerr ckerr deleted the miniak/eslintrc branch September 20, 2022 18:25
@release-clerk
Copy link

release-clerk bot commented Sep 20, 2022

No Release Notes

This was referenced Sep 20, 2022
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Sep 20, 2022

I have automatically backported this PR to "19-x-y", please check out #35745

@trop
Copy link
Contributor

trop bot commented Sep 20, 2022

I have automatically backported this PR to "20-x-y", please check out #35746

@trop
Copy link
Contributor

trop bot commented Sep 20, 2022

I have automatically backported this PR to "21-x-y", please check out #35747

@trop trop bot added in-flight/20-x-y merged/21-x-y PR was merged to the "21-x-y" branch. and removed target/20-x-y target/21-x-y PR should also be added to the "21-x-y" branch. labels Sep 20, 2022
@commit-lint commit-lint bot mentioned this pull request Jan 16, 2023
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@miniak @khalwa
chore: add missing .eslintrc.json files to limit imports properly (el…
d85c58d 
…ectron#35719)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees

@miniak miniak

Labels
merged/21-x-y PR was merged to the "21-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miniak @ckerr