[Bug]: The global content client will init twice on the startup

[netflt]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for a bug report that matches the one I want to file, without success.

Electron Version

19

What operating system are you using?

Other (specify below)

Operating System Version

macOS

What arch are you using?

Other (specify below)

Last Known Working Electron version

No response

Expected Behavior

The global content client should init once on startup.

Actual Behavior

The global content client will init twice on the startup and it cause a memory leak.causes.

Testcase Gist URL

No response

Additional Information

These days I try to debug the electron source and found that the global content client will init twice on startup because the ElectronMainDelegate didn't override the CreateContentClient.

The first time, it call the ContentMainDelegate::CreateContentClient to create an ContentClient instance.

void SetContentClient(ContentClient* client) {
  /*
  if(g_client != nullptr)
  {
      DCHECK(false);
  }
  */
  g_client = client;
}

//ContentClientCreator::Create
static void Create(ContentMainDelegate* delegate) {
    ContentClient* client = delegate->CreateContentClient();
    DCHECK(client);
    SetContentClient(client);
  }

Then the global ContentClient will be set as an ElectronContentClient instance in ElectronMainDelegate::BasicStartupComplete

So the first one is never to be used and never to be free until the process exit.