fix: correct redefinition which is invalid C++ #36096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
previously requested changes
Oct 20, 2022
There was a problem hiding this comment.
I'd be happy to take a patch that only updated our changes to Chromium, but this also changes some existing code in Chromium.
It's worth noting that neither Chromium nor Electron supports building with GCC.
I'm requesting changes here, but if you get the GetPageAllocator definition fixed upstream (see here for details about contributing to Chromium), I'd be happy to also update our patch to match.
nornagon
reviewed
Oct 20, 2022
patches/chromium/export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch
Outdated
Show resolved
Hide resolved
brjsp
force-pushed
the
PageAllocator-fpermissive
branch
2 times, most recently
from
cf54af7
to
17a3a87
Compare
|
The patch seems to be broken now :/ but it looks better! |
brjsp
force-pushed
the
PageAllocator-fpermissive
branch
from
17a3a87
to
520e1e0
Compare
|
fixed and rebased patch |
brjsp
force-pushed
the
PageAllocator-fpermissive
branch
2 times, most recently
from
2434932
to
2ce9d80
Compare
|
Looks like this is FTBFS now: |
brjsp
force-pushed
the
PageAllocator-fpermissive
branch
from
2ce9d80
to
1aa1719
Compare
|
fixed, somehow the second file got lost |
zcbenz
approved these changes
Jan 5, 2023
See https://stackoverflow.com/a/15538759 for an explanation of class scope. GCC gives an error when compiling this code: https://godbolt.org/z/sYhc3cMjE
zcbenz
force-pushed
the
PageAllocator-fpermissive
branch
from
1aa1719
to
e50ab4a
Compare
codebytere
approved these changes
Feb 7, 2023
zcbenz
dismissed
nornagon’s stale review
Dismiss as the problem has been fixed.
|
No Release Notes |
codebytere
pushed a commit
that referenced
this pull request
Feb 8, 2023
* fix: correct redefinition which is invalid C++ See https://stackoverflow.com/a/15538759 for an explanation of class scope. GCC gives an error when compiling this code: https://godbolt.org/z/sYhc3cMjE * Update export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch --------- Co-authored-by: Cheng Zhao <zcbenz@gmail.com> Co-authored-by: Cheng Zhao <github@zcbenz.com>
codebytere
pushed a commit
that referenced
this pull request
Feb 8, 2023
* fix: correct redefinition which is invalid C++ See https://stackoverflow.com/a/15538759 for an explanation of class scope. GCC gives an error when compiling this code: https://godbolt.org/z/sYhc3cMjE * Update export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch --------- Co-authored-by: Cheng Zhao <zcbenz@gmail.com> Co-authored-by: Cheng Zhao <github@zcbenz.com>
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* fix: correct redefinition which is invalid C++ See https://stackoverflow.com/a/15538759 for an explanation of class scope. GCC gives an error when compiling this code: https://godbolt.org/z/sYhc3cMjE * Update export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch --------- Co-authored-by: Cheng Zhao <zcbenz@gmail.com> Co-authored-by: Cheng Zhao <github@zcbenz.com>
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
* fix: correct redefinition which is invalid C++ See https://stackoverflow.com/a/15538759 for an explanation of class scope. GCC gives an error when compiling this code: https://godbolt.org/z/sYhc3cMjE * Update export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch --------- Co-authored-by: Cheng Zhao <zcbenz@gmail.com> Co-authored-by: Cheng Zhao <github@zcbenz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://stackoverflow.com/a/15538759 for an explanation of class scope.
GCC gives an error when compiling this code: https://godbolt.org/z/sYhc3cMjE
Notes: none