build: determine electron version from tags not files #36106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
added
target/19-x-y
target/21-x-y
MarshallOfSound
force-pushed
the
tag-based-versioning
branch
from
1848135
to
d7cd709
Compare
MarshallOfSound
force-pushed
the
tag-based-versioning
branch
from
45b6849
to
16b8516
Compare
VerteDinde
approved these changes
Oct 24, 2022
|
No Release Notes |
|
I was unable to backport this PR to "19-x-y" cleanly; |
|
I was unable to backport this PR to "20-x-y" cleanly; |
|
I was unable to backport this PR to "21-x-y" cleanly; |
|
I was unable to backport this PR to "22-x-y" cleanly; |
trop
bot
removed
the
target/21-x-y
|
@VerteDinde has manually backported this PR to "21-x-y", please check out #36135 |
|
@VerteDinde has manually backported this PR to "20-x-y", please check out #36136 |
|
@VerteDinde has manually backported this PR to "19-x-y", please check out #36137 |
jkleinsc
pushed a commit
that referenced
this pull request
Oct 27, 2022
* build: determine electron version from tags not files (#36106) * build: determine electron version from tags not files * build: make electron_version dependent on packed-refs and git HEAD * build: do not delete electron/.git * build: do not revert a commit we didn't make * build: gen version file instead of just writing it * build: update cache and ninja targets * build: copy resource.h to generated electron.rc * build: electron_win32_resources should be public deps * build: also copy the icon Co-authored-by: MarshallOfSound <marshallofsound@electronjs.org> * build: ensure get-version runs in the electron git checkout (#36128) * build: strip v in the getElectronVersion helper Co-authored-by: MarshallOfSound <marshallofsound@electronjs.org> Co-authored-by: Samuel Attard <sam@electronjs.org> Co-authored-by: Samuel Attard <sattard@salesforce.com>
trop
bot
added
merged/22-x-y
VerteDinde
added a commit
that referenced
this pull request
Oct 28, 2022
* build: determine electron version from tags not files (#36106) * build: determine electron version from tags not files * build: make electron_version dependent on packed-refs and git HEAD * build: do not delete electron/.git * build: do not revert a commit we didn't make * build: gen version file instead of just writing it * build: update cache and ninja targets * build: copy resource.h to generated electron.rc * build: electron_win32_resources should be public deps * build: also copy the icon Co-authored-by: MarshallOfSound <marshallofsound@electronjs.org> * chore: fixup patches * chore: update patches * build: ensure get-version runs in the electron git checkout (#36128) * build: strip v in the getElectronVersion helper * build: use npm@7 for npm view command Co-authored-by: MarshallOfSound <marshallofsound@electronjs.org> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Samuel Attard <sam@electronjs.org> Co-authored-by: Samuel Attard <sattard@salesforce.com>
trop
bot
added
merged/21-x-y
VerteDinde
added a commit
that referenced
this pull request
Oct 30, 2022
* build: determine electron version from tags not files (#36106) * build: determine electron version from tags not files * build: make electron_version dependent on packed-refs and git HEAD * build: do not delete electron/.git * build: do not revert a commit we didn't make * build: gen version file instead of just writing it * build: update cache and ninja targets * build: copy resource.h to generated electron.rc * build: electron_win32_resources should be public deps * build: also copy the icon Co-authored-by: MarshallOfSound <marshallofsound@electronjs.org> * chore: fixup patches * chore: update patches * build: ensure get-version runs in the electron git checkout (#36128) * build: strip v in the getElectronVersion helper * build: use npm@7 for npm view command Co-authored-by: Samuel Attard <sam@electronjs.org> Co-authored-by: MarshallOfSound <marshallofsound@electronjs.org> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Samuel Attard <sattard@salesforce.com>
VerteDinde
added a commit
that referenced
this pull request
Oct 30, 2022
* build: determine electron version from tags not files (#36106) * build: determine electron version from tags not files * build: make electron_version dependent on packed-refs and git HEAD * build: do not delete electron/.git * build: do not revert a commit we didn't make * build: gen version file instead of just writing it * build: update cache and ninja targets * build: copy resource.h to generated electron.rc * build: electron_win32_resources should be public deps * build: also copy the icon Co-authored-by: MarshallOfSound <marshallofsound@electronjs.org> * chore: fixup patches * chore: update patches * build: ensure get-version runs in the electron git checkout (#36128) * build: strip v in the getElectronVersion helper * build: use npm@7 for npm view command Co-authored-by: Samuel Attard <sam@electronjs.org> Co-authored-by: MarshallOfSound <marshallofsound@electronjs.org> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Samuel Attard <sattard@salesforce.com>
2 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* build: determine electron version from tags not files * build: make electron_version dependent on packed-refs and git HEAD * build: do not delete electron/.git * build: do not revert a commit we didn't make * build: gen version file instead of just writing it * build: update cache and ninja targets * build: copy resource.h to generated electron.rc * build: electron_win32_resources should be public deps * build: also copy the icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a few cool things
electron.rcis now generated instead of being updated via the bump scriptSUPPORT.mdis no longer updated automatically (we should replace this with some other automation)All this means that we should be able to turn on signed commit enforcement because sudowoodo will no longer need to push commits.
Notes: no-notes