Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed MenuItem documentation to use the same formatting for all role options #36119

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 24, 2022

Backport of #36112

See that PR for details.

Notes: no-notes

… role options (#36112)

Fixed MenuItem documentation

Some of the items in the list of possible roles were formatted differently, which made it harder to read.
Sorry if this was intended, but I found it easier to read with them all formatted the same.

Co-authored-by: flynow10 <37031514+flynow10@users.noreply.github.com>
@trop trop bot added 21-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Oct 24, 2022
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: lgtm

Copy link

@electron-docs-reviewer electron-docs-reviewer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of the Electron Docs Team

@zcbenz zcbenz merged commit ed999f5 into 21-x-y Oct 25, 2022
@zcbenz zcbenz deleted the trop/21-x-y-bp-docs-fixed-menuitem-documentation-to-use-the-same-formatting-for-all-role-options-1666637532050 branch October 25, 2022 11:45
@release-clerk
Copy link

release-clerk bot commented Oct 25, 2022

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
21-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants