fix: ensure autofill popup view is > 1x1 in size #36121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
previously approved these changes
Oct 25, 2022
codebytere
dismissed
their stale review
Oops meant to comment - it doesn't look like popup_->popup_bounds_.Union returns a gfx::Rect
zcbenz
approved these changes
Oct 25, 2022
zcbenz
requested changes
Oct 25, 2022
| @@ -224,7 +224,8 @@ void AutofillPopupView::DoUpdateBoundsAndRedrawPopup() { | |||
| if (!popup_) | |||
| return; | |||
|
|
|||
| GetWidget()->SetBounds(popup_->popup_bounds_); | |||
| GetWidget()->SetBounds(popup_->popup_bounds_.Union( | |||
| gfx::Rect(popup_->popup_bounds_.origin(), gfx::Size(1, 1)))); | |||
There was a problem hiding this comment.
If popup_->popup_bounds_ could be empty, then so would be popup_->popup_bounds_in_view(), which is used in some other places.
|
It was also mentioned in #26667 that passing zero size to |
codebytere
reviewed
Jan 25, 2023
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
zcbenz
approved these changes
Jan 26, 2023
|
No Release Notes |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* fix: ensure autofill popup view is > 1x1 in size ref electron#26667 * Update shell/browser/ui/views/autofill_popup_view.cc Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
* fix: ensure autofill popup view is > 1x1 in size ref electron#26667 * Update shell/browser/ui/views/autofill_popup_view.cc Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #26667
Checklist
npm testpassesRelease Notes
Notes: none