Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: mksnapshot args shipped with v21 doen't work properly #36309

Closed
3 tasks done
LabhanshAgrawal opened this issue Nov 10, 2022 · 0 comments · Fixed by #36378
Closed
3 tasks done

[Bug]: mksnapshot args shipped with v21 doen't work properly #36309

LabhanshAgrawal opened this issue Nov 10, 2022 · 0 comments · Fixed by #36378
Assignees
Labels

Comments

@LabhanshAgrawal
Copy link

LabhanshAgrawal commented Nov 10, 2022

Preflight Checklist

Electron Version

21.2.2

What operating system are you using?

macOS

Operating System Version

13

What arch are you using?

arm64 (including Apple Silicon)

Last Known Working Electron version

20.3.4

Expected Behavior

Running mksnapshot works normally.

Actual Behavior

It fails.
It succeeds if I remove

--turbo-profiling-input
../../v8/tools/builtins-pgo/arm64.profile

from the mksnapshot_args file.

I'm not able to find this arm64.profile file anywhere to try and build with it being present. (the path mentioned is two levels up, so I'm guessing it is somehow missed while creating the zip and relative path ends up here)

Testcase Gist URL

No response

Additional Information

Contents of the mksnapshot_args file across recent versions

Screenshot 2022-11-10 at 20 26 02

Note: I'm running mksnapshot via electron-mksnapshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Fixed For Next Release
Development

Successfully merging a pull request may close this issue.

3 participants