Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 65d46507a0c9 from chromium #36584

Merged
merged 8 commits into from
Dec 19, 2022

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Dec 6, 2022

[Merge to M108] Replace raw pointer to LocalMuter with weak ptr

This CL replaces a raw pointer to LocalMuter with a weak ptr. Additional
info about this bug here: http://crbug/1377783

(cherry picked from commit 9989b93eb12c93b9351d5bf2872c1069ef5f7d01)

Bug: 1377783
Change-Id: Id821ea800ba12f1cfae4677fc591c12dec112852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3997421
Reviewed-by: Paul Semel paulsemel@chromium.org
Reviewed-by: Olga Sharonova olka@chromium.org
Commit-Queue: Evan Liu evliu@google.com
Cr-Original-Commit-Position: refs/heads/main@{#1068776}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4024547
Auto-Submit: Evan Liu evliu@google.com
Owners-Override: Srinivas Sista srinivassista@chromium.org
Bot-Commit: Rubber Stamper rubber-stamper@appspot.gserviceaccount.com
Commit-Queue: Rubber Stamper rubber-stamper@appspot.gserviceaccount.com
Reviewed-by: Evan Liu evliu@google.com
Cr-Commit-Position: refs/branch-heads/5359@{#824}
Cr-Branched-From: 27d3765d341b09369006d030f83f582a29eb57ae-refs/heads/main@{#1058933}

Ref electron/security#254

Notes: Security: backported fix for CVE-2022-4179.

@ppontes ppontes requested review from a team as code owners December 6, 2022 16:21
@ppontes ppontes added 21-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes labels Dec 6, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Dec 6, 2022
@ppontes ppontes added the wip ⚒ label Dec 6, 2022
@ppontes ppontes force-pushed the cherry-pick/21-x-y/chromium/65d46507a0c9 branch from 046359a to 1fbcd2f Compare December 6, 2022 22:24
@ppontes ppontes removed the wip ⚒ label Dec 6, 2022
Copy link

@PraveenNanda124 PraveenNanda124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@nornagon nornagon merged commit 570c146 into 21-x-y Dec 19, 2022
@nornagon nornagon deleted the cherry-pick/21-x-y/chromium/65d46507a0c9 branch December 19, 2022 21:28
@release-clerk
Copy link

release-clerk bot commented Dec 19, 2022

Release Notes Persisted

Security: backported fix for CVE-2022-4179.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
21-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants