docs: add mdn link to web-request-filter.md #36618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
When I was using the Electron docs I wanted to know how to use [webRequest.onBeforeSendHeaders](https://www.electronjs.org/docs/latest/api/web-request#webrequestonbeforesendheadersfilter-listener) but I was unable to correctly guess the correct format for the `WebRequestFilter` URL strings, and there was no explanation in the Electron docs. Eventually I googled it and found the MDN article which helped me. Co-authored-by: Hugh Davey <9026053+hughjdavey@users.noreply.github.com>
Co-authored-by: Black-Hole <158blackhole@gmail.com> Co-authored-by: Hugh Davey <9026053+hughjdavey@users.noreply.github.com>
Co-authored-by: Black-Hole <158blackhole@gmail.com> Co-authored-by: Hugh Davey <9026053+hughjdavey@users.noreply.github.com>
trop
bot
added
21-x-y
backport
VerteDinde
approved these changes
Dec 8, 2022
VerteDinde
deleted the
trop/21-x-y-bp-docs-add-mdn-link-to-web-request-filter-md-1670537551300
branch
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #36603
See that PR for details.
Notes: none