fix: strip branded binaries #36641
Merged
fix: strip branded binaries #36641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertgzr
force-pushed
the
branded-linux-binaries
branch
from
a5c191c
to
a9e1111
Compare
When creating branded release builds and using scripts/strip-binaries.py on Linux, the final artifacts end up unstripped due to the static set of binaries considered for stripping. With this patch the name of the electron binary is taken from the BRANDING.json `project_name` key. Signed-off-by: Robert Günzler <r@gnzler.io>
robertgzr
force-pushed
the
branded-linux-binaries
branch
from
a9e1111
to
d7e0302
Compare
nornagon
approved these changes
Dec 13, 2022
nornagon
added
target/21-x-y
nornagon
added
semver/patch
jkleinsc
approved these changes
Dec 13, 2022
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Release Notes Persisted
|
This was referenced Dec 13, 2022
|
I have automatically backported this PR to "22-x-y", please check out #36654 |
|
I have automatically backported this PR to "21-x-y", please check out #36655 |
trop
bot
added
in-flight/22-x-y
and removed
target/22-x-y
|
I have automatically backported this PR to "23-x-y", please check out #36656 |
trop
bot
added
in-flight/23-x-y
merged/23-x-y
trop
bot
added
merged/21-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
When creating branded release builds and using scripts/strip-binaries.py on Linux, the final artifacts end up unstripped due to the static set of binaries considered for stripping. With this patch the name of the electron binary is taken from the BRANDING.json `project_name` key. Signed-off-by: Robert Günzler <r@gnzler.io> Signed-off-by: Robert Günzler <r@gnzler.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When creating branded release builds and using scripts/strip-binaries.py
on Linux, the final artifacts end up unstripped due to the static set of
binaries considered for stripping.
With this patch the name of the electron binary is taken from the
BRANDING.json
project_namekey.Checklist
npm testpassestests are changed or addedrelevant documentation, tutorials, templates and examples are changed or addedRelease Notes
Notes: Fix binary stripping for branded release builds on Linux