Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use chrome headers in net.request for everything except cookie #36666

Merged
merged 1 commit into from
Dec 21, 2022
Merged

fix: use chrome headers in net.request for everything except cookie #36666

merged 1 commit into from
Dec 21, 2022

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Dec 14, 2022 •
edited

Description of Change

Chrome's parsed headers contain everything except the cookies (ref), so use those and add in the set-cookie header at the end.

Closes #27895.

Checklist

Release Notes

Notes: Fixed net.request response headers missing Content-Type.

@nornagon nornagon added no-backport semver/patch backwards-compatible bug fixes labels Dec 14, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 14, 2022
@nornagon nornagon requested a review from zcbenz December 14, 2022 18:02
PraveenNanda124
PraveenNanda124 reviewed Dec 15, 2022
View reviewed changes
Copy link

@PraveenNanda124 PraveenNanda124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 15, 2022
@nornagon nornagon mentioned this pull request Dec 15, 2022
Merged
5 tasks
VerteDinde
VerteDinde approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but not blocking

shell/browser/api/electron_api_url_loader.cc Show resolved Hide resolved
@nornagon nornagon merged commit 8f23b15 into main Dec 21, 2022
@nornagon nornagon deleted the net-headers branch December 21, 2022 22:53
@release-clerk
Copy link

release-clerk bot commented Dec 21, 2022

Release Notes Persisted

Fixed net.request response headers missing Content-Type.

@Soltus Soltus mentioned this pull request Feb 16, 2023
Closed
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@nornagon @khalwa
fix: use chrome headers in net.request for everything except cookie (e…
3e86e3b 
…lectron#36666)
@commit-lint commit-lint bot mentioned this pull request Mar 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PraveenNanda124 PraveenNanda124 PraveenNanda124 left review comments

@VerteDinde VerteDinde VerteDinde approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
no-backport semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

net.request response is missing content-type header in 304 responses
3 participants
@nornagon @VerteDinde @PraveenNanda124