Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 77208afba04d from chromium #36681

Merged
merged 4 commits into from
Jan 4, 2023

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Dec 16, 2022

Make WidgetBase::BeginMainFrame resilient to disposed 'this'

This patch makes sure that WidgetBase::BeginMainFrame can finish
execution even if processing the RAF-throttled handlers
(DispatchRafAlignedInput) destroys 'this' instance.

(cherry picked from commit af6e22c14bec7ad64115b24ece6d423f144214ca)

Bug: chromium:1381871
Change-Id: I81aa4ba697f80f8666bb2a3b5542cac210b1efa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4030809
Reviewed-by: Dave Tapuska dtapuska@chromium.org
Commit-Queue: Jaroslav Sevcik jarin@chromium.org
Cr-Original-Commit-Position: refs/heads/main@{#1072864}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4068023
Auto-Submit: Jaroslav Sevcik jarin@chromium.org
Commit-Queue: Dave Tapuska dtapuska@chromium.org
Cr-Commit-Position: refs/branch-heads/5359@{#1053}
Cr-Branched-From: 27d3765d341b09369006d030f83f582a29eb57ae-refs/heads/main@{#1058933}

Ref electron/security#264

Notes: Security: backported fix for CVE-2022-4438.

@ppontes ppontes requested review from a team as code owners December 16, 2022 02:02
@ppontes ppontes added 21-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes labels Dec 16, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Dec 16, 2022
@ppontes ppontes force-pushed the cherry-pick/21-x-y/chromium/77208afba04d branch from 5c28e37 to f8a4692 Compare December 20, 2022 10:58
@jkleinsc jkleinsc merged commit 8a150a2 into 21-x-y Jan 4, 2023
@jkleinsc jkleinsc deleted the cherry-pick/21-x-y/chromium/77208afba04d branch January 4, 2023 15:50
@release-clerk
Copy link

release-clerk bot commented Jan 4, 2023

Release Notes Persisted

Security: backported fix for CVE-2022-4438.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
21-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants