Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 9b3d0e2f1aab from chromium #36685

Merged
merged 3 commits into from
Dec 19, 2022

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Dec 16, 2022

Keep a reference to the transfer buffer in Dawn read/write handles.

Previously the Dawn read/write handles in the GPU process only contained
a pointer to the inside of a shmem region owned by a gpu::Buffer that
had a different lifetime. This could allow a renderer process to
deallocate the memory from underneath the handle which is bad.

Fix this by keepind a scoped_refptr to the gpu::Buffer inside the
read/write handles to extend the lifetime of the shmem to be at least as
big as the handle's.

Fixed: chromium:1393177
Change-Id: I9d9c18d5155a46e0e3a01d385d221a6370bd2bea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4056276
Reviewed-by: Austin Eng enga@chromium.org
Commit-Queue: Corentin Wallez cwallez@chromium.org
Cr-Commit-Position: refs/heads/main@{#1076828}

Notes: Security: backported fix for 1393177.

@ppontes ppontes requested review from a team as code owners December 16, 2022 02:22
@ppontes ppontes added 21-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes labels Dec 16, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Dec 16, 2022
@nornagon nornagon merged commit 5828a25 into 21-x-y Dec 19, 2022
@nornagon nornagon deleted the cherry-pick/21-x-y/chromium/9b3d0e2f1aab branch December 19, 2022 21:26
@release-clerk
Copy link

release-clerk bot commented Dec 19, 2022

Release Notes Persisted

Security: backported fix for 1393177.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
21-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants