chore: cherry-pick 819d876e1bb8 from chromium #36687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppontes
added
21-x-y
backport-check-skip
electron-cation
bot
added
new-pr 🌱
ppontes
force-pushed
the
cherry-pick/21-x-y/chromium/819d876e1bb8
branch
from
3572de8
to
c3fae7c
Compare
nornagon
approved these changes
Dec 19, 2022
ppontes
force-pushed
the
cherry-pick/21-x-y/chromium/819d876e1bb8
branch
from
1235a57
to
7e8c16f
Compare
|
failures are flakes; merging. |
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix UAF caused by vector operations during iteration
MediaInspectorContextImpl::CullPlayers iterates through dead_players_
to remove their events, but this can cause a GC event which can
end up adding more players to the |dead_players_| vector, causing
it to get re-allocated and it's iterators invalidated.
We can fix this simply by not using an iterator, and removing elements
from the vector before we trigger any GC operations that might cause
other changes to the vector.
Bug: 1383991
Change-Id: I59f5824c156ff58cf6b55ac9b942c8efdb1ed65a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4064295
Reviewed-by: Andrey Kosyakov caseq@chromium.org
Commit-Queue: Ted (Chromium) Meyer tmathmeyer@chromium.org
Reviewed-by: Thomas Guilbert tguilbert@chromium.org
Cr-Commit-Position: refs/heads/main@{#1078842}
Notes: Security: backported fix for CVE-2022-4436.