Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update code highlights in tutorial #36691

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Conversation

zurawiki
Copy link
Contributor

@zurawiki zurawiki commented Dec 16, 2022

Description of Change

The highlighted lines in the code snippets were unaligned, which could cause a newcomer unneeded confusion on what lines need to be changed.

Checklist

  • PR description included and stakeholders cc'd

Release Notes

notes: none

The highlighted lines in the code snippets were unaligned,
which could cause a newcomer unneeded confusion on what
lines need to be changed.
@welcome
Copy link

welcome bot commented Dec 16, 2022

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours labels Dec 16, 2022
@zurawiki zurawiki changed the title docs: fix code highlighting in preload tutorial docs: update code highlights in tutorial Dec 16, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 17, 2022
@nornagon nornagon added the target/23-x-y PR should also be added to the "23-x-y" branch. label Dec 19, 2022
@codebytere codebytere merged commit 28cfacc into electron:main Jan 2, 2023
@welcome
Copy link

welcome bot commented Jan 2, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Jan 2, 2023

No Release Notes

@trop
Copy link
Contributor

trop bot commented Jan 2, 2023

I have automatically backported this PR to "23-x-y", please check out #36767

@trop trop bot added in-flight/23-x-y and removed target/23-x-y PR should also be added to the "23-x-y" branch. labels Jan 2, 2023
@zurawiki zurawiki deleted the patch-1 branch January 2, 2023 17:03
@zurawiki zurawiki restored the patch-1 branch January 2, 2023 17:03
@zurawiki zurawiki deleted the patch-1 branch January 2, 2023 17:03
@zurawiki zurawiki restored the patch-1 branch January 2, 2023 17:03
@zurawiki zurawiki deleted the patch-1 branch January 2, 2023 17:03
@trop trop bot added merged/23-x-y PR was merged to the "23-x-y" branch. and removed in-flight/23-x-y labels Jan 10, 2023
@erickzhao erickzhao added the target/22-x-y PR should also be added to the "22-x-y" branch. label Jan 12, 2023
erickzhao pushed a commit to erickzhao/ericktron that referenced this pull request Jan 12, 2023
docs: fix code highlighting in preload tutorial

The highlighted lines in the code snippets were unaligned,
which could cause a newcomer unneeded confusion on what
lines need to be changed.
@trop
Copy link
Contributor

trop bot commented Jan 12, 2023

@erickzhao has manually backported this PR to "22-x-y", please check out #36893

@trop trop bot added in-flight/22-x-y and removed target/22-x-y PR should also be added to the "22-x-y" branch. labels Jan 12, 2023
@trop trop bot added merged/22-x-y PR was merged to the "22-x-y" branch. and removed in-flight/22-x-y labels Jan 12, 2023
jkleinsc pushed a commit that referenced this pull request Jan 12, 2023
docs: update code highlights in tutorial (#36691)

docs: fix code highlighting in preload tutorial

The highlighted lines in the code snippets were unaligned,
which could cause a newcomer unneeded confusion on what
lines need to be changed.

Co-authored-by: Roger Zurawicki <zurawiki@users.noreply.github.com>
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
docs: fix code highlighting in preload tutorial

The highlighted lines in the code snippets were unaligned,
which could cause a newcomer unneeded confusion on what
lines need to be changed.
gecko19 pushed a commit to brightsign/electron that referenced this pull request Feb 28, 2023
docs: fix code highlighting in preload tutorial

The highlighted lines in the code snippets were unaligned,
which could cause a newcomer unneeded confusion on what
lines need to be changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 merged/22-x-y PR was merged to the "22-x-y" branch. merged/23-x-y PR was merged to the "23-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants