Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix incorrect highlight in an example snippet #36700

Merged
merged 1 commit into from
Dec 20, 2022
Merged

docs: Fix incorrect highlight in an example snippet #36700

merged 1 commit into from
Dec 20, 2022

Conversation

MAPGarrett
Copy link
Contributor

Description of Change

At the moment, the "Communicating between processes" main.js snippet highlights the line containing }) when the relevant line for this part of the tutorial is ipcMain.handle('ping', () => 'pong'), this change just updates the highlighted line.

Checklist

  • PR description included and stakeholders cc'd
  • relevant documentation, tutorials, templates and examples are changed or added

Release Notes

Notes: none

At the moment, the "Communicating between processes" `main.js` snippet highlights the line containing `})` when the relevant line is `ipcMain.handle('ping', () => 'pong')`.
@welcome
Copy link

welcome bot commented Dec 19, 2022

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 19, 2022
@MAPGarrett MAPGarrett changed the title Fix incorrect highlight in an example snippet docs: Fix incorrect highlight in an example snippet Dec 19, 2022
@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes labels Dec 19, 2022
@nornagon nornagon added the target/23-x-y PR should also be added to the "23-x-y" branch. label Dec 19, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 20, 2022
@nornagon nornagon merged commit 8c837fd into electron:main Dec 20, 2022
@welcome
Copy link

welcome bot commented Dec 20, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Dec 20, 2022

No Release Notes

@trop
Copy link
Contributor

trop bot commented Dec 20, 2022

I have automatically backported this PR to "23-x-y", please check out #36713

@trop trop bot added in-flight/23-x-y and removed target/23-x-y PR should also be added to the "23-x-y" branch. labels Dec 20, 2022
@MAPGarrett MAPGarrett deleted the patch-1 branch December 21, 2022 09:16
@trop trop bot added merged/23-x-y PR was merged to the "23-x-y" branch. and removed in-flight/23-x-y labels Jan 2, 2023
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
Fix incorrect highlight in an example snippet

At the moment, the "Communicating between processes" `main.js` snippet highlights the line containing `})` when the relevant line is `ipcMain.handle('ping', () => 'pong')`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 merged/23-x-y PR was merged to the "23-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants