Make sure V8 handles are deleted on UI thread #3676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should rely on the destructor to cleanup everything, instead of putting them in the Destroy method.
This saves the step of manually keeping the global template object, which is easy to forget then leak.
zcbenz
added a commit
that referenced
this pull request
Dec 3, 2015
Make sure V8 handles are deleted on UI thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem that some V8 handles are deleted on IO thread when a V8 function is used as protocol handlers, close #3419.
There also some more improvements on the management of JavaScript objects' lifetime to make the fix possible, currently a native JavaScript object could be deleted in following ways:
destroymethod.