fix: RTL WindowButtonsProxy buttons
#36839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
deepak1556
reviewed
Jan 9, 2023
codebytere
force-pushed
the
rtl-correction
branch
2 times, most recently
from
571cf4f
to
e738173
Compare
deepak1556
approved these changes
Jan 9, 2023
codebytere
force-pushed
the
rtl-correction
branch
from
e738173
to
b73faf0
Compare
zcbenz
approved these changes
Jan 10, 2023
|
Release Notes Persisted
|
This was referenced Jan 10, 2023
|
I have automatically backported this PR to "23-x-y", please check out #36850 |
trop
bot
added
in-flight/23-x-y
and removed
target/23-x-y
|
I have automatically backported this PR to "22-x-y", please check out #36851 |
|
I have automatically backported this PR to "21-x-y", please check out #36852 |
trop
bot
added
in-flight/21-x-y
merged/21-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* fix: RTL WindowButtonsProxy buttons * chore: address review feedback
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
* fix: RTL WindowButtonsProxy buttons * chore: address review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #36539.
Fixes an issue where custom traffic lights wouldn't properly respect an application's locale setting if it differed from the system setting and had a different directionality. This was happening because macOS native elements set their origin and axis based upon the system locale RTL setting, and so even when we took RTL into account in
WindowButtonsProxyit would still be incorrect. To fix this, we set Apple app-level defaults to force RTL or LTR if it differs from the system locale. This PR also adds support for--force-ui-directionsimilar to CL:956297Tested with https://gist.github.com/8dc6c09539222ee3ad86146123982011, using an English system locale setting.
Before
After
Checklist
npm testpassesRelease Notes
Notes: Fixed an RTL issue that could happen in some locales when calling
BrowserWindow.setTrafficLightPosition()on macOS.