fix: Cmd+Tab not working when exiting kiosk mode #36854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
zcbenz
reviewed
Jan 11, 2023
codebytere
force-pushed
the
fix-cmd-tab-kiosk-interaction
branch
from
b347b1e
to
995b5f2
Compare
zcbenz
approved these changes
Jan 13, 2023
|
Release Notes Persisted
|
This was referenced Jan 16, 2023
|
I have automatically backported this PR to "23-x-y", please check out #36917 |
trop
bot
added
in-flight/23-x-y
and removed
target/23-x-y
|
I have automatically backported this PR to "22-x-y", please check out #36918 |
|
I have automatically backported this PR to "21-x-y", please check out #36919 |
trop
bot
added
in-flight/22-x-y
merged/23-x-y
trop
bot
added
merged/21-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #33503.
Refs #25470.
Fixes an issue on macOS when trying to switch processes with
Cmd+Tabafter exiting Kiosk Mode. We need to ensure that presentation options are reset after exiting fullscreen, otherwise the fullscreen action takes precedence and causes them to improperly be reset.Tested with https://gist.github.com/40902920c8fb6c0e2ebcd8fdb936cbf6.
Checklist
npm testpassesRelease Notes
Notes: Fixes an issue on macOS when trying to switch processes with
Cmd+Tabafter exiting Kiosk Mode.