Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable microtask queue per window agent #36870

Merged
merged 3 commits into from
Jan 11, 2023

Conversation

deepak1556
Copy link
Member

Description of Change

Fixes #36813

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 11, 2023
@deepak1556 deepak1556 requested a review from a team as a code owner January 11, 2023 10:27
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you open a CL or issue upstream to see what V8 thinks about this change? it'd be preferable not to have to float this patch ad infinitum imo - beyond that this LGTM

@deepak1556
Copy link
Member Author

Yes the change is worth upstreaming but I might not be able to work on it anytime soon, happy to receive help!

@deepak1556 deepak1556 merged commit fefb22a into main Jan 11, 2023
@deepak1556 deepak1556 deleted the robo/enable_context_microtasks branch January 11, 2023 16:59
@release-clerk
Copy link

release-clerk bot commented Jan 11, 2023

No Release Notes

@codebytere
Copy link
Member

/trop run backport-to 23-x-y

@trop
Copy link
Contributor

trop bot commented Feb 8, 2023

The backport process for this PR has been manually initiated - sending your PR to 23-x-y!

@trop
Copy link
Contributor

trop bot commented Feb 8, 2023

I have automatically backported this PR to "23-x-y", please check out #37189

@trop trop bot added in-flight/23-x-y merged/23-x-y PR was merged to the "23-x-y" branch. and removed in-flight/23-x-y labels Feb 8, 2023
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
* chore: enable microtask queue per window agent

* chore: switch policies on context microtask queue

* fix: ensure node::Environment is valid
gecko19 pushed a commit to brightsign/electron that referenced this pull request Feb 28, 2023
* chore: enable microtask queue per window agent

* chore: switch policies on context microtask queue

* fix: ensure node::Environment is valid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/23-x-y PR was merged to the "23-x-y" branch. new-pr 🌱 PR opened in the last 24 hours no-backport semver/none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Microtask queues per WindowAgent.
2 participants