Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 0f481c9ddf2a from v8 #36882

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Jan 11, 2023

Merged: [wasm][turbofan] Load 32-bit values more efficiently

When loading a 32-bit value from the stack, just load 32 bit and
zero-extend them into the target register, instead of loading the full
64 bits.

As there are things to fix (see https://crbug.com/1356461), we only
enable this optimization for Wasm for now.

Also include the related fix https://crrev.com/c/4096985.

R=mslekova@chromium.org

(cherry picked from commit 2ee52447c878721c89a55a780eb689ecba6817d3)
(cherry picked from commit a38209949fcbf045231c316e2d790b8b70ccb7ef)

Bug: chromium:1395604
Change-Id: I54a2182ada6fadbfcf5565f0dc8d4f477ecff393
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4110897
Reviewed-by: Maya Lekova mslekova@chromium.org
Commit-Queue: Clemens Backes clemensb@chromium.org
Cr-Commit-Position: refs/branch-heads/10.8@{#46}
Cr-Branched-From: f1bc03fd6b4c201abd9f0fd9d51fb989150f97b9-refs/heads/10.8.168@{#1}
Cr-Branched-From: 237de893e1c0a0628a57d0f5797483d3add7f005-refs/heads/main@{#83672}

Notes: Security: backported fix for 1395604.

@ppontes ppontes requested review from a team as code owners January 11, 2023 14:27
@ppontes ppontes added 21-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes labels Jan 11, 2023
@ppontes ppontes marked this pull request as draft January 11, 2023 18:39
@ppontes ppontes marked this pull request as ready for review January 11, 2023 21:25
@codebytere codebytere merged commit e9b5cd7 into 21-x-y Jan 12, 2023
@codebytere codebytere deleted the cherry-pick/21-x-y/v8/0f481c9ddf2a branch January 12, 2023 14:18
@release-clerk
Copy link

release-clerk bot commented Jan 12, 2023

Release Notes Persisted

Security: backported fix for 1395604.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
21-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants