Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for unlocking with Apple Watch #36935

Merged
merged 1 commit into from
Jan 26, 2023
Merged

feat: add support for unlocking with Apple Watch #36935

merged 1 commit into from
Jan 26, 2023

Conversation

mbarbero
Copy link
Contributor

Description of Change

If you have an Apple laptop in clamshell mode (lid is closed) and you don't have an Apple Keyboard with TouchID, LAPolicyDeviceOwnerAuthenticationWithBiometrics policy cannot be evaluated, and CanPromptTouchID returns false even if you have an Apple Watch capable of unlocking the laptop. This new policy is mirroring macOS behavior.

Checklist

Release Notes

Notes: SystemPreferences::CanPromptTouchID (macOS) now supports Apple Watch

@welcome
Copy link

welcome bot commented Jan 18, 2023

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 18, 2023
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Left one comment - once that's addressed it should be good to go.

shell/browser/api/electron_api_system_preferences_mac.mm Outdated Show resolved Hide resolved
@RateThePaladin
Copy link

Thanks for this change! Has been a pet peeve of mine for a while

Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api lgtm

@codebytere
Copy link
Member

API LGTM

Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@zcbenz
Copy link
Member

zcbenz commented Jan 26, 2023

This has enough API LGTMs and should be ready to merge, but I'm not sure whether it is a feat, it is more like a bug fix to me.

@codebytere codebytere merged commit 1486cbd into electron:main Jan 26, 2023
@welcome
Copy link

welcome bot commented Jan 26, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Jan 26, 2023

Release Notes Persisted

SystemPreferences::CanPromptTouchID (macOS) now supports Apple Watch

khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
gecko19 pushed a commit to brightsign/electron that referenced this pull request Feb 28, 2023
@mbarbero mbarbero deleted the patch-1 branch May 16, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants