-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for unlocking with Apple Watch #36935
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Left one comment - once that's addressed it should be good to go.
Thanks for this change! Has been a pet peeve of mine for a while |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
api lgtm
API LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
This has enough API LGTMs and should be ready to merge, but I'm not sure whether it is a |
Congrats on merging your first pull request! 🎉🎉🎉 |
Release Notes Persisted
|
Description of Change
If you have an Apple laptop in clamshell mode (lid is closed) and you don't have an Apple Keyboard with TouchID,
LAPolicyDeviceOwnerAuthenticationWithBiometrics
policy cannot be evaluated, andCanPromptTouchID
returns false even if you have an Apple Watch capable of unlocking the laptop. This new policy is mirroring macOS behavior.Checklist
npm test
passesRelease Notes
Notes:
SystemPreferences::CanPromptTouchID
(macOS) now supports Apple Watch