docs: Change factuality and word choice in app.runningUnderARM64Translation #36947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added "or WOW" to the phrase, "when they are running the x64 version under Rosetta", to reflect the use of a supported platform, Windows, as a possible scenario. Changed the wording of that same sentence to make it appear clearer. "incorrectly" to "mistakenly" and moved this word to before the verb instead of the end of the sentence.
|
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
GGIEnrike
changed the title
GGIEnrike
changed the title
electron-cation
bot
added
documentation 📓
semver/patch
jkleinsc
approved these changes
Jan 18, 2023
jkleinsc
added
target/22-x-y
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
No Release Notes |
This was referenced Jan 19, 2023
|
I have automatically backported this PR to "23-x-y", please check out #36963 |
trop
bot
added
in-flight/23-x-y
and removed
target/23-x-y
|
I have automatically backported this PR to "22-x-y", please check out #36964 |
trop
bot
added
in-flight/22-x-y
merged/22-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…lation (electron#36947) Change factuality and word choice. Added "or WOW" to the phrase, "when they are running the x64 version under Rosetta", to reflect the use of a supported platform, Windows, as a possible scenario. Changed the wording of that same sentence to make it appear clearer. "incorrectly" to "mistakenly" and moved this word to before the verb instead of the end of the sentence.
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
…lation (electron#36947) Change factuality and word choice. Added "or WOW" to the phrase, "when they are running the x64 version under Rosetta", to reflect the use of a supported platform, Windows, as a possible scenario. Changed the wording of that same sentence to make it appear clearer. "incorrectly" to "mistakenly" and moved this word to before the verb instead of the end of the sentence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "or WOW" to display the use of Windows as a possible scenario.
Changed the wording of that same sentence in
app.runningUnderARM64Translationto make it appear clearer. Replaced "incorrectly" with "mistakenly" and moved this word to before the verb instead of the end of the sentence.Description of Change
Checklist
npm testpassesRelease Notes
Notes: none