Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated deep link docs #36952

Merged
merged 5 commits into from
Jan 26, 2023
Merged

docs: updated deep link docs #36952

merged 5 commits into from
Jan 26, 2023

Conversation

mehimanshupatil
Copy link
Contributor

Description of Change

Checklist

Release Notes

Notes: In deep link docs the windows specific code also contains macOS/Linux code which is confusing.

@welcome
Copy link

welcome bot commented Jan 19, 2023

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 19, 2023
@mehimanshupatil mehimanshupatil changed the title updated deep link docs docs: updated deep link docs Jan 19, 2023
@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes labels Jan 19, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 20, 2023
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
@zcbenz zcbenz added no-backport target/22-x-y PR should also be added to the "22-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch. and removed no-backport labels Jan 26, 2023
@zcbenz zcbenz merged commit 8d008c9 into electron:main Jan 26, 2023
@release-clerk
Copy link

release-clerk bot commented Jan 26, 2023

Release Notes Persisted

In deep link docs the windows specific code also contains macOS/Linux code which is confusing.

@welcome
Copy link

welcome bot commented Jan 26, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@trop
Copy link
Contributor

trop bot commented Jan 26, 2023

I have automatically backported this PR to "23-x-y", please check out #37031

@trop
Copy link
Contributor

trop bot commented Jan 26, 2023

I have automatically backported this PR to "22-x-y", please check out #37032

@trop trop bot added in-flight/22-x-y merged/23-x-y PR was merged to the "23-x-y" branch. and removed target/23-x-y PR should also be added to the "23-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. in-flight/23-x-y labels Jan 26, 2023
@trop trop bot added merged/22-x-y PR was merged to the "22-x-y" branch. and removed in-flight/22-x-y labels Jan 30, 2023
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
* removed open-url listener from windows code

* updated deep-link fiddle

* fixed url hash to app.requestSingleInstanceLock

* code linted

* updated website url to relative file path

Co-authored-by: David Sanders <dsanders11@ucsbalum.com>

Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
gecko19 pushed a commit to brightsign/electron that referenced this pull request Feb 28, 2023
* removed open-url listener from windows code

* updated deep-link fiddle

* fixed url hash to app.requestSingleInstanceLock

* code linted

* updated website url to relative file path

Co-authored-by: David Sanders <dsanders11@ucsbalum.com>

Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 merged/22-x-y PR was merged to the "22-x-y" branch. merged/23-x-y PR was merged to the "23-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants