fix: make plugin helper executable unconditional #36971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
added
semver/patch
MarshallOfSound
approved these changes
Jan 20, 2023
|
Release Notes Persisted
|
This was referenced Jan 21, 2023
|
I have automatically backported this PR to "23-x-y", please check out #36977 |
trop
bot
added
in-flight/23-x-y
and removed
target/23-x-y
|
I have automatically backported this PR to "22-x-y", please check out #36978 |
trop
bot
added
in-flight/22-x-y
merged/22-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs https://bugs.chromium.org/p/chromium/issues/detail?id=1342679
Plugin helper executable has use cases outside the plugin architecture of chromium to allow loading third-party unsigned libraries. We also leverage this capability in the UtilityProcess API
enable_pluginsis already on track for deletion in upstream so they have made this executable not conditional on that flag, the PR aligns to do the same in Electron. You can also refer to the linked issue as to why the executable has not been renamed./cc @miniak FYI
Release Notes
Notes: Remove plugin helper checks on macOS gated behind enable_plugins buildflag