fix: nodeIntegrationInWorker fails to boot in AudioWorklets #37041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
added
semver/patch
nornagon
changed the title
codebytere
approved these changes
Jan 27, 2023
codebytere
force-pushed
the
audio-worklet-init
branch
from
3bc98bc
to
983963a
Compare
codebytere
force-pushed
the
audio-worklet-init
branch
from
983963a
to
b6827e6
Compare
|
Release Notes Persisted
|
This was referenced Feb 2, 2023
|
I have automatically backported this PR to "22-x-y", please check out #37102 |
trop
bot
added
in-flight/22-x-y
and removed
target/22-x-y
|
I have automatically backported this PR to "21-x-y", please check out #37103 |
|
I have automatically backported this PR to "23-x-y", please check out #37104 |
trop
bot
added
in-flight/21-x-y
merged/23-x-y
3 tasks
trop
bot
added
merged/21-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When 'nodeIntegrationInWorker: true', worker_init is loaded in worker scopes.
That script assumed that
selfwas always available, which isn't the case inAudioWorkletGlobalScope.
Found while investigating #37038, but this does not address that issue.
Checklist
npm testpassesRelease Notes
Notes: Fixed audio worklet scripts failing to run when
nodeIntegrationInWorker: true.