Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: ensure correct ninja is used #37070

Merged
merged 1 commit into from
Jan 31, 2023
Merged

ci: ensure correct ninja is used #37070

merged 1 commit into from
Jan 31, 2023

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 30, 2023

Backport of #37069

See that PR for details.

Notes: none

@trop trop bot requested a review from jkleinsc January 30, 2023 17:36
@trop trop bot mentioned this pull request Jan 30, 2023
Merged
2 tasks
@trop trop bot added 21-x-y backport This is a backport PR semver/none labels Jan 30, 2023
codebytere
codebytere previously approved these changes Jan 30, 2023
View reviewed changes
@codebytere codebytere dismissed their stale review January 30, 2023 21:54

change does not apply here

@codebytere
Copy link
Member

@jkleinsc i think we'll need to do something different on older branches 🤔

KeyError: 'Could not find any dependency called src/third_party/ninja.'
Error: bad package version (line 1): bad version "": not an instance ID, a ref or a tag

@jkleinsc jkleinsc force-pushed the trop/21-x-y-bp-ci-ensure-correct-ninja-is-used-1675100163820 branch 4 times, most recently from 7915201 to add01d5 Compare January 31, 2023 18:15
@trop @jkleinsc
ci: ensure correct ninja is used
cfa67a0 
Co-Authored-By: John Kleinschmidt <jkleinsc@electronjs.org>
@jkleinsc jkleinsc force-pushed the trop/21-x-y-bp-ci-ensure-correct-ninja-is-used-1675100163820 branch from d2a6093 to cfa67a0 Compare January 31, 2023 20:03
@jkleinsc
Copy link
Contributor

Merging as CI failure unrelated to PR change.

@jkleinsc jkleinsc merged commit 751fc04 into 21-x-y Jan 31, 2023
@jkleinsc jkleinsc deleted the trop/21-x-y-bp-ci-ensure-correct-ninja-is-used-1675100163820 branch January 31, 2023 22:13
@release-clerk
Copy link

release-clerk bot commented Jan 31, 2023

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere left review comments

Assignees
No one assigned
Labels
21-x-y backport This is a backport PR semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @jkleinsc