Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ensure correct ninja is used #37071

Merged

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 30, 2023

Backport of #37069

See that PR for details.

Notes: none

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
@trop trop bot requested a review from jkleinsc January 30, 2023 17:36
@trop trop bot mentioned this pull request Jan 30, 2023
2 tasks
@trop trop bot added 22-x-y backport This is a backport PR semver/none labels Jan 30, 2023
@patchup patchup bot requested a review from a team as a code owner January 30, 2023 18:43
miniak
miniak previously requested changes Jan 30, 2023
Copy link
Contributor

@miniak miniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is patches/chromium/cherry-pick-57c54ae221d6.patch being removed?

@jkleinsc
Copy link
Contributor

@miniak looks like we got that patch via upstream in #37019.

Looks like #37022 was accidentally merged after #37019.

@codebytere codebytere force-pushed the trop/22-x-y-bp-ci-ensure-correct-ninja-is-used-1675100166682 branch from f4cfedc to 3d04ef0 Compare January 30, 2023 22:20
@jkleinsc jkleinsc merged commit fe3baa8 into 22-x-y Jan 31, 2023
@jkleinsc jkleinsc deleted the trop/22-x-y-bp-ci-ensure-correct-ninja-is-used-1675100166682 branch January 31, 2023 17:36
@release-clerk
Copy link

release-clerk bot commented Jan 31, 2023

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants