Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable basic a11y when voice control is active #37146

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 6, 2023

Backport of #37122

See that PR for details.

Notes: Basic accessibility support is now enabled when macOS Voice Control is activated to allow for full voice control of Electron applications

@trop trop bot requested a review from MarshallOfSound February 6, 2023 11:33
@trop trop bot added 22-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Feb 6, 2023
codebytere
codebytere previously approved these changes Feb 6, 2023
@codebytere
Copy link
Member

../../electron/shell/browser/mac/electron_application.mm:202:67: error: no member named 'flags' in 'ui::AXMode'
  if (!ax_state->GetAccessibilityMode().has_mode(ui::kAXModeBasic.flags())) {
                                                 ~~~~~~~~~~~~~~~~ ^
1 error generated.

Co-authored-by: Robo <hop2deep@gmail.com>
@jkleinsc jkleinsc merged commit fc2261f into 22-x-y Feb 7, 2023
@jkleinsc jkleinsc deleted the trop/22-x-y-bp-fix-enable-basic-a11y-when-voice-control-is-active-1675683174324 branch February 7, 2023 21:01
@release-clerk
Copy link

release-clerk bot commented Feb 7, 2023

Release Notes Persisted

Basic accessibility support is now enabled when macOS Voice Control is activated to allow for full voice control of Electron applications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
22-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants