test: ensure fullscreen test is retryable #37179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
added
semver/none
and removed
new-pr 🌱
MarshallOfSound
changed the title
codebytere
approved these changes
Feb 8, 2023
VerteDinde
approved these changes
Feb 8, 2023
|
No Release Notes |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
spec: ensure fullscreen test is retryable
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
spec: ensure fullscreen test is retryable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With retries in mocha only the
beforeEachis re-run, we were shutting down the localhost server in anafterEachbut setting it up in abefore. This moves the logic to abeforeEachand avoids a race condition where the server isn't listening when the test runs.Notes: no-notes