New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update app.{set|get}LoginItemSettings(settings)
#37244
Conversation
03e8bcf
to
8e60529
Compare
Note: macOS is failing becuase it needs a more recent SDK. Chromium has updated it upstream already, so this will be fixed as soon as https://github.com/electron/electron/pull/37130/files#diff-920de4a8729bdf120a0908a0f013f2e3a0e7c40acf0fdc961bbff77ca9106929L57 lands and this can be rebased. |
8e60529
to
7dbbe44
Compare
Is this blocked by something, @codebytere? |
7dbbe44
to
1754e51
Compare
1754e51
to
cc0e82b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
cc0e82b
to
065195c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - test failures are unrelated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
1318fd3
to
ef3b84e
Compare
9ceb66e
to
7170b5c
Compare
Release Notes Persisted
|
* feat: update app.{set|get}LoginItemSettings(settings) * test: fixup and add tests * docs: add type link * chore: name -> serviceName
* feat: update app.{set|get}LoginItemSettings(settings) * test: fixup and add tests * docs: add type link * chore: name -> serviceName
Description of Change
Closes #37560.
Refs #37228
Refs electron/governance#533
This PR updated
app.setLoginItemSettings(settings)
andapp.getLoginItemSettings(settings)
on macOS 13 to use a single streamlined underlying API on both Mac App Store and regular macOS builds. This will remove several configuration and settings options, includingopenAsHidden
inapp.setLoginItemSettings
andwasOpenedAtLogin
andwasOpenedAsHidden
inapp.getLoginItemSettings
.This simplifies the underlying logic in accordance to the APIs apple has outlined for usage and improve parity between MAS and non-MAS builds. This will also allow developers to register app service objects, launch daemons, and login item services to launch on startup.
Checklist
npm test
passesRelease Notes
Notes: Migrated
app.{set|get}LoginItemSettings(settings)
to use Apple's new recommended underlying framework on macOS.