Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Add event to WebContents to react to changes of isCurrentlyAudible #37352

Closed
3 tasks done
Prinzhorn opened this issue Feb 20, 2023 · 1 comment · Fixed by #37366
Closed
3 tasks done

[Feature Request]: Add event to WebContents to react to changes of isCurrentlyAudible #37352

Prinzhorn opened this issue Feb 20, 2023 · 1 comment · Fixed by #37366
Labels
component/webcontents enhancement ✨

Comments

@Prinzhorn
Copy link
Contributor

Preflight Checklist

Problem Description

Chromium only shows the button to mute/unmute a tab when it actually has media playing. Once the media has paused, the button will eventually fade away. Electron does not offer a way to react to this change.

Proposed Solution

Either a single change event like audible-change or two symmetrical events along the lines of did-become-audible and stopped-being-audible.

Alternatives Considered

Poll isCurrentlyAudible

Additional Information

No response
@codebytere
Copy link
Member

codebytere commented Feb 21, 2023 •
edited

I think this is reasonable - I'll see what i can do!

@codebytere codebytere mentioned this issue Feb 21, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/webcontents enhancement ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: expose audio-state-changed on webContents electron/electron
2 participants
@Prinzhorn @codebytere