-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: setWindowOpenHandler changes default stylesheet for plain text files in dark theme #37737
Comments
This was introduced somewhere in v22.0.0-nightly.20220809...v22.0.0-nightly.20220810, most likely in #34526 from the announced breaking change of replacing the |
Is this the same as #36538? |
@jeremyspiegel probably not? I agree they do look similar, but if 36538 was present in 21.3.1 and 37737 first appeared in v22.0.0-nightly.20220810 then they can't be the same issue 💫 |
@ckerr sorry you're right. Using |
I would guess that the underlying issue behind both is something about the change to use the |
I agree that they look like duplicates. Feel free to close this one. |
Well now I'm confused 😄 Can someone test & confirm whether or not 36538 is present in 21.3.1? If so, I don't see how these two tickets can be the same issue |
#36538 is present in 21.3.1. There's probably a single underlying cause for both issues. The problematic code was likely introduced earlier in #28054, and only affected the |
@ckerr, it's the same issue as #36538. I have the fix for these issues in #36914 but CI was giving me trouble with the tests, so I shelved it and then got sidetracked with other work. I've confirmed the fix in that PR fixes the gist provided in this issue. I'll pick it back up and see if I can make the tests happy. |
Duplicate of #36538. |
Preflight Checklist
Electron Version
>=22.0.0
What operating system are you using?
Windows
Operating System Version
Windows 10 Enterprise 22H2
What arch are you using?
x64
Last Known Working Electron version
21
Expected Behavior
Click on the link to open the plain text file in a new window.
Text should be readable, e.g. white text on dark background.
Actual Behavior
Text is not readable. It's white text on white background.
This seems to only happen if there is a
setWindowOpenHandler
. If you comment out that line, a dark background is applied.Testcase Gist URL
https://gist.github.com/ajafff/8d9e8eb8cc0a7ec2297f2445c54f5526
Additional Information
No response
The text was updated successfully, but these errors were encountered: