Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add thermal states to powerMonitor #37935

Merged
merged 2 commits into from Apr 19, 2023
Merged

feat: add thermal states to powerMonitor #37935

merged 2 commits into from Apr 19, 2023

Conversation

nornagon
Copy link
Member

Description of Change

Expose some more base::PowerMonitor stuff. Specifically, thermal state and CPU
throttling.

See
https://source.chromium.org/chromium/chromium/src/+/refs/heads/main:base/power_monitor/power_observer.h;l=35;drc=991110a34dafb7233475cdfa91c3416d1e91b724

Checklist

Release Notes

Notes: Added thermal management information to powerMonitor.

@nornagon nornagon added semver/minor backwards-compatible functionality target/24-x-y PR should also be added to the "24-x-y" branch. labels Apr 11, 2023
@electron-cation electron-cation bot added api-review/requested 🗳 new-pr 🌱 PR opened in the last 24 hours labels Apr 11, 2023
@miniak
Copy link
Contributor

miniak commented Apr 11, 2023

API LGTM

@VerteDinde VerteDinde added the target/25-x-y PR should also be added to the "25-x-y" branch. label Apr 12, 2023
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@codebytere codebytere merged commit ba835dd into main Apr 19, 2023
17 checks passed
@codebytere codebytere deleted the pm-thermal branch April 19, 2023 09:46
@release-clerk
Copy link

release-clerk bot commented Apr 19, 2023

Release Notes Persisted

Added thermal management information to powerMonitor.

@trop
Copy link
Contributor

trop bot commented Apr 19, 2023

I have automatically backported this PR to "24-x-y", please check out #38027

@trop trop bot added in-flight/24-x-y and removed target/24-x-y PR should also be added to the "24-x-y" branch. labels Apr 19, 2023
@trop
Copy link
Contributor

trop bot commented Apr 19, 2023

I have automatically backported this PR to "25-x-y", please check out #38028

@trop trop bot added in-flight/25-x-y merged/25-x-y PR was merged to the "25-x-y" branch. and removed target/25-x-y PR should also be added to the "25-x-y" branch. in-flight/25-x-y labels Apr 19, 2023
@trop trop bot added merged/24-x-y PR was merged to the "24-x-y" branch and removed in-flight/24-x-y labels May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review/approved ✅ merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants