Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix Codespaces prebuilds with missing comma #38052

Merged
merged 1 commit into from Apr 20, 2023

Conversation

JasonEtco
Copy link
Contributor

@JasonEtco JasonEtco commented Apr 20, 2023

Description of Change

This PR adds one comma to fix the errors that cropped up in Codespaces Prebuilds, due to some errant copy-pasta from #37765.

cc @MarshallOfSound

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes

Release Notes

Notes: none

@welcome
Copy link

welcome bot commented Apr 20, 2023

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 20, 2023
@JasonEtco JasonEtco changed the title Fix Codespaces prebuilds with missing comma build: Fix Codespaces prebuilds with missing comma Apr 20, 2023
@electron-cation electron-cation bot added semver/none and removed new-pr 🌱 PR opened in the last 24 hours labels Apr 20, 2023
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MarshallOfSound MarshallOfSound merged commit cf4c46c into electron:main Apr 20, 2023
13 of 17 checks passed
@welcome
Copy link

welcome bot commented Apr 20, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Apr 20, 2023

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants