Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: getNormalBounds() returns actual window bounds for transparent maximized windows #38180

Closed
3 tasks done
tomasmi opened this issue May 4, 2023 · 2 comments · Fixed by #38218
Closed
3 tasks done

Comments

@tomasmi
Copy link

tomasmi commented May 4, 2023

Preflight Checklist

Electron Version

25.0.0

What operating system are you using?

Windows

Operating System Version

Windows 10

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

getNormalBounds() should return last bounds before transparent windows is maximized or minimized

Actual Behavior

getNormalBounds() returning current bounds when transparent windows is maximized or minimized

Testcase Gist URL

No response

Additional Information

No response

@codebytere codebytere added platform/windows 25-x-y blocked/need-repro Needs a test case to reproduce the bug labels May 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Hello @tomasmi. Thanks for reporting this and helping to make Electron better!

Would it be possible for you to make a standalone testcase with only the code necessary to reproduce the issue? For example, Electron Fiddle is a great tool for making small test cases and makes it easy to publish your test case to a gist that Electron maintainers can use.

Stand-alone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it removes all unnecessary variables from the equation, and it can also provide the basis for automated regression tests.

Now adding the blocked/need-repro label for this reason. After you make a test case, please link to it in a followup comment. This issue will be closed in 10 days if the above is not addressed.

@tomasmi
Copy link
Author

tomasmi commented May 4, 2023

Hello @tomasmi. Thanks for reporting this and helping to make Electron better!

Would it be possible for you to make a standalone testcase with only the code necessary to reproduce the issue? For example, Electron Fiddle is a great tool for making small test cases and makes it easy to publish your test case to a gist that Electron maintainers can use.

Stand-alone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it removes all unnecessary variables from the equation, and it can also provide the basis for automated regression tests.

Now adding the blocked/need-repro label for this reason. After you make a test case, please link to it in a followup comment. This issue will be closed in 10 days if the above is not addressed.

This should show the error
The console prints

{ x: 560, y: 280, width: 800, height: 600 }
{ x: 0, y: 0, width: 1920, height: 1160 }

As you can see in the test before maximize getNormalBounds is returning
{ x: 560, y: 280, width: 800, height: 600 }
when calling getNormalBounds after maximize it is returning
{ x: 0, y: 0, width: 1920, height: 1160 }
https://gist.github.com/tomasmi/baea6d78117d801f5bd5b1ad9a3e64c4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Unsorted Items
Development

Successfully merging a pull request may close this issue.

2 participants