You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If anyone wants to work on this, please just create a PR rather then comment here. If a PR mentions this issue it will be visible here, so in the absence of said linked PRs, please feel free to create a PR - we don't assign issues like this to external contributors. 🙂
The phrasings that
electron/docs-parser
recognizes for string union types is fairly narrow, and it looks like there's a handful of places in the docs where the phrasing is not being picked up as string union types.Fix these and add smoke tests with
// @ts-expect-error
to ensure type unions are being used. See #38336 for an example.Alternatively, extend the phrasings that
electron/docs-parser
recognizes, and add the smoke tests.A (possibly non-exhaustive) list of ones which aren't being picked up. There's an upstream issue preventing certain values from being picked up.
electron/docs/api/webview-tag.md
Lines 1091 to 1093 in 2a16c73
electron/docs/api/web-contents.md
Lines 796 to 798 in 2a16c73
electron/docs/api/native-image.md
Lines 308 to 309 in 2a16c73
electron/docs/api/session.md
Lines 577 to 580 in 2a16c73
electron/docs/api/session.md
Lines 581 to 582 in 2a16c73
electron/docs/api/desktop-capturer.md
Lines 91 to 92 in e08c583
The text was updated successfully, but these errors were encountered: