Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: win.isMaximized() for transparent windows on Windows #38344

Merged
merged 1 commit into from May 17, 2023
Merged

fix: win.isMaximized() for transparent windows on Windows #38344

merged 1 commit into from May 17, 2023

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 17, 2023

Backport of #38234

See that PR for details.

Notes: Fixed an issue where calling win.minimize() directly after calling win.maximize(), and then calling win.isMaximized() incorrectly returns true.

@trop trop bot requested a review from codebytere May 17, 2023 08:17
@trop trop bot mentioned this pull request May 17, 2023
Merged
4 tasks
@trop trop bot added 23-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 17, 2023
@codebytere codebytere force-pushed the trop/23-x-y-bp-fix-win-ismaximized-for-transparent-windows-on-windows-1684311446754 branch from 5f0d595 to 93ca684 Compare May 17, 2023 08:25
@trop @codebytere
fix: win.isMaximized() for transparent windows
5a43ec9 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@codebytere codebytere force-pushed the trop/23-x-y-bp-fix-win-ismaximized-for-transparent-windows-on-windows-1684311446754 branch from 93ca684 to 5a43ec9 Compare May 17, 2023 11:14
@codebytere codebytere merged commit 672c312 into 23-x-y May 17, 2023
13 checks passed
@codebytere codebytere deleted the trop/23-x-y-bp-fix-win-ismaximized-for-transparent-windows-on-windows-1684311446754 branch May 17, 2023 12:49
@release-clerk
Copy link

release-clerk bot commented May 17, 2023

Release Notes Persisted

Fixed an issue where calling win.minimize() directly after calling win.maximize(), and then calling win.isMaximized() incorrectly returns true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
23-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@codebytere